Skip to content

Feature/on event handlers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

davidjbradshaw
Copy link

Hi,

Just playing around with this to make the interface a bit more 'react' and enforce the oneway stuff.

This is just some ideas for now and not ready to merge. Just wondering if you had a simple test project to test it against, as I've only linted it so far and to check if you happy to take a PR.

To finish this I want make a small change to iFrame-Resizer so that it handles the close method a bit differently when called by this. Also need to update the docs and I guess it would be nice to add a few Jest tests. Maybe add a simple demo project as well.

Anyway just wondered what your thoughts where for now.

Dave.

@brudil
Copy link
Owner

brudil commented Jun 20, 2017

Hi Dave. Just had a quick glance - this all looks great. I currently don't have a demo/test repo but could put one together. I've been meaning to get around to adding tests but was never sure of the best way to implement them.

@davidjbradshaw
Copy link
Author

Hey,

It would be great if you could create a simple Create React App based demo in a /example folder that can link to the example iframe content pages in the iframe-resizer examples folder and mirrors the functionality of the example parent page.

Test wise I'm a big fan of Jest for testing anything React based. However, the getting started page looks simple.

Maybe we can bring all this together in a dev branch for now.

@brudil
Copy link
Owner

brudil commented Jun 20, 2017

Turns out I did actually have a little example app, it's currently just a static and dynamic height iframe. I've pushed it under /example in a dev branch.

create-react-app doesn't allow importing components from outside the src directory, so a npm link in the project root and a npm link react-iframe-resizer in the example directory is required.

I'll hook it up with the pages you mentioned.

@davidjbradshaw
Copy link
Author

Cool will take a look when I next get a spare moment in a couple of days hopefully.

Currently busy getting ready for www.goingnowhere.org.

@brudil
Copy link
Owner

brudil commented Jun 28, 2017

I've ported the iframe-resizer example to our create-react-app example - it uses the new on* handling props in this PR.

@brudil brudil mentioned this pull request Jan 30, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants