-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/on event handlers #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/on event handlers #3
Conversation
Hi Dave. Just had a quick glance - this all looks great. I currently don't have a demo/test repo but could put one together. I've been meaning to get around to adding tests but was never sure of the best way to implement them. |
Hey, It would be great if you could create a simple Create React App based demo in a /example folder that can link to the example iframe content pages in the iframe-resizer examples folder and mirrors the functionality of the example parent page. Test wise I'm a big fan of Jest for testing anything React based. However, the getting started page looks simple. Maybe we can bring all this together in a dev branch for now. |
Turns out I did actually have a little example app, it's currently just a static and dynamic height iframe. I've pushed it under /example in a create-react-app doesn't allow importing components from outside the src directory, so a I'll hook it up with the pages you mentioned. |
Cool will take a look when I next get a spare moment in a couple of days hopefully. Currently busy getting ready for www.goingnowhere.org. |
I've ported the iframe-resizer example to our create-react-app example - it uses the new on* handling props in this PR. |
Hi,
Just playing around with this to make the interface a bit more 'react' and enforce the oneway stuff.
This is just some ideas for now and not ready to merge. Just wondering if you had a simple test project to test it against, as I've only linted it so far and to check if you happy to take a PR.
To finish this I want make a small change to iFrame-Resizer so that it handles the close method a bit differently when called by this. Also need to update the docs and I guess it would be nice to add a few Jest tests. Maybe add a simple demo project as well.
Anyway just wondered what your thoughts where for now.
Dave.