Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add metric to monitor available split block tasks #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pashinov
Copy link
Member

No description provided.

@pashinov pashinov requested a review from 0xdeafbeef February 10, 2025 12:16
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.87%. Comparing base (ec56ab8) to head (8e3cdbd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   42.86%   42.87%           
=======================================
  Files         278      278           
  Lines       51883    51885    +2     
  Branches    51883    51885    +2     
=======================================
+ Hits        22242    22245    +3     
+ Misses      28478    28477    -1     
  Partials     1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 65 to 70
expr: Union[str, List[Union[str, Expr]], Expr],
title: str,
unit_format=UNITS.NUMBER_FORMAT,
labels=[],
legend_format: str | None = None,
) -> Panel:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use black scripts/gen-dashboard.py or simply revert these double indentations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pashinov pashinov force-pushed the feat/split-block-metrics branch from 9f72fdb to ed7d9eb Compare February 13, 2025 12:12
@pashinov pashinov force-pushed the feat/split-block-metrics branch from ed7d9eb to 8e3cdbd Compare February 13, 2025 12:13
@pashinov pashinov requested a review from 0xdeafbeef February 13, 2025 12:33
@0xdeafbeef 0xdeafbeef enabled auto-merge February 13, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants