Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain service message limits #577

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

MrWad3r
Copy link
Member

@MrWad3r MrWad3r commented Jan 30, 2025

No description provided.

@MrWad3r MrWad3r requested review from 0xdeafbeef and Rexagon January 30, 2025 13:21
@MrWad3r MrWad3r force-pushed the feature/bc-message-limits branch from 4ad5a3b to 4af22af Compare February 3, 2025 17:04
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 37.57962% with 98 lines in your changes missing coverage. Please review.

Project coverage is 42.82%. Comparing base (65b6dbb) to head (79922f5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
util/src/serde_helpers.rs 0.00% 60 Missing ⚠️
block-util/src/message/ext_msg_repr.rs 67.50% 14 Missing and 12 partials ⚠️
rpc/src/endpoint/jrpc/mod.rs 0.00% 5 Missing ⚠️
core/src/blockchain_rpc/service.rs 40.00% 2 Missing and 1 partial ⚠️
rpc/src/endpoint/proto/mod.rs 0.00% 3 Missing ⚠️
block-util/src/block/block_proof_stuff.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   42.88%   42.82%   -0.07%     
==========================================
  Files         278      278              
  Lines       51891    51944      +53     
  Branches    51891    51944      +53     
==========================================
- Hits        22256    22245      -11     
- Misses      28473    28532      +59     
- Partials     1162     1167       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@0xdeafbeef 0xdeafbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rexagon Rexagon force-pushed the feature/bc-message-limits branch from e14b42a to 9807923 Compare February 7, 2025 13:57
@Rexagon Rexagon force-pushed the feature/bc-message-limits branch from 9807923 to e6375c2 Compare February 21, 2025 17:44
@Rexagon Rexagon force-pushed the feature/bc-message-limits branch from e6375c2 to 79922f5 Compare February 21, 2025 17:48
@Rexagon Rexagon added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 70e51bb Feb 21, 2025
9 of 11 checks passed
@Rexagon Rexagon deleted the feature/bc-message-limits branch February 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants