Fix symlink resolve #195
Merged
Fix symlink resolve #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
previously requested changes
Jul 2, 2019
|
I made it, but for unknown reasons, it fails on runner. Locally everything is okay. |
|
Original problem is dependents/node-filing-cabinet#81 |
|
The new test still fails for me locally, on my Mac. |
|
I've added this to #197. |
ljharb
added a commit
that referenced
this pull request
Aug 1, 2019
- [New] `core`: add `_debug_agent` core module, in node 1 through 7 - [Fix] `preserveSymlinks: false` ensure that files are realpathed (#197, #195) - [Refactor] make `maybeUnwrapSymlink` - [Meta] clean up license so github can detect it - [Dev Deps] update `tape` - [Tests] fix symlinks in windows/appveyor - [Tests] up to `node` `v12.7`, `v10.16`, `v8.16` - [Tests] gitignore file created in tests; remove it in test setup
This was referenced Dec 2, 2019
This was referenced Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
preserveSymlinks = falsedoes not work in sync mode.