-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0] Wrap StagehandPage and StagehandContext #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4430aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kamath
changed the title
Wrap StagehandPage and StagehandContext
[2.0] Wrap StagehandPage and StagehandContext
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fire
seanmcguire12
approved these changes
Dec 20, 2024
Merged
kamath
added a commit
that referenced
this pull request
Jan 3, 2025
Set stagehand env to "LOCAL" if we default to "LOCAL" (#320) * bug fix: set this.env to LOCAL if BROWSERBASE_API_KEY is not defined * changeset [2.0] Wrap StagehandPage and StagehandContext (#319) * [feat]: start to wrap page * ignore pnpm lock * wrap * temp * rewrite example * sample playwright * working with context * e2e pass context * rm example * uploads/downloads e2e * ci e2e * CI env * changeset * cleanup context test update extract_capacitor_info eval (#323) * use new site * prettier Only startDomDebug if it's enabled (#325) * Only startDomDebug if it's enabled * changeset --------- rebase Version Packages (#321) Reduce eval spend (#337) Remove duplicate logging and export page/context types (#344) Throw custom error if context is referenced without initialization (#353) * Throw error if context is referenced without initialization. Also remove act/extract handlers from lib/index * changeset fix(logger): enable disabling logger (#355) [fix]: Fix -types exposed to the client to match the expected contract (#358) Remove Stagehand Nav (#360) * Remove Stagehand Nav * changeset Co-Authored-By: Anirudh Kamath <[email protected]> Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
We want Stagehand to provide a better Playwright experience, so when the user runs
stagehand.page
we can return a playwrightPage
wrapper asStagehandPage
what changed
examples/example.ts
to just be a scratchpad. Good Stagehand code can be found withnpx create-browser-app
stagehand.page
in aStagehandPage
objectstagehand.context
in aStagehandContext
objectevals/deterministic
that test Playwright + Browserbase SDK. Added to CI as well before AI evalstest plan
npm run e2e
. This just runs Playwright tests usingStagehand