Skip to content

Commit

Permalink
Fix python_cpp test on Mac. Link staticly when building extension, so…
Browse files Browse the repository at this point in the history
… that the extension doesn't require installing protobuf library. (protocolbuffers#2232)
  • Loading branch information
TeBoring committed Oct 10, 2016
1 parent 5be6325 commit daba665
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ setenv =
commands =
python setup.py -q build_py
python: python setup.py -q build
cpp: python setup.py -q build --cpp_implementation --warnings_as_errors
cpp: python setup.py -q build --cpp_implementation --warnings_as_errors --compile_static_extension
python: python setup.py -q test -q
cpp: python setup.py -q test -q --cpp_implementation
python: python setup.py -q test_conformance
Expand Down
3 changes: 2 additions & 1 deletion tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ internal_build_cpp() {
fi

./autogen.sh
./configure
./configure CXXFLAGS="-fPIC" # -fPIC is needed for python cpp test.
# See python/setup.py for more details
make -j2
}

Expand Down

0 comments on commit daba665

Please sign in to comment.