Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Introduces the
rustc_portable
module that exports either rustc identifiers (likeDefId
) or our proxy. Together withcfg_attr
this makes it more ergonomic to define data structures that are used outside of rustc but depend on those identifiers.Why Does It Need To?
I really didn't like the
code blocks. I think they are hard to read and easy to get wrong. Now you can write
Checklist
good record of what changed.
if necessary
Works if it compiles 😄
.github/workflows/rust.yml
) either as compiler test or integration test.Or justification for their omission from CI has been provided in this PR
description.