Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the PR template descriptions not comments #35

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

JustusAdam
Copy link
Collaborator

What Changed?

This removes the comment tags from the PR template.

Why Does It Need To?

This is to encourage the submitter of the PR to overwrite the description so it won't show up in the final, squashed commit message.

Checklist

  • Above description has been filled out so that upon quash merge we have a
    good record of what changed.
  • New functions, methods, types are documented. Old documentation is updated
    if necessary
  • Documentation in Notion has been updated
  • Tests for new behaviors are provided
    • New test suites (if any) ave been added to the CI tests (in
      .github/workflows/rust.yml) either as compiler test or integration test.
      Or justification for their omission from CI has been provided in this PR
      description.

This is to encourage the submitter of the PR to overwrite the description
so it won't show up in the final, squashed commit message.
@JustusAdam JustusAdam merged commit 010d341 into main Sep 14, 2023
4 checks passed
@JustusAdam JustusAdam deleted the no-comments-in-pr-template branch September 20, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant