-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor repo into Cargo workspace with scaffolding for Rust-based queries #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the refactoring. Here are some thoughts I had on this code so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm dot sure how much I agree with the df
prefix. Since we're introducing new names we should make it consistent with the paper. I would suggest we call the graph crate spdg
, and the checker policy-check
. dfpp
we can leave for now since people are already used to that.
Uhhh, maybe we could rename the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the build.rs
for the properties? Are those actually necessary? And weren't you going to copy the build.rs
to the explorer also?
What Changed?
The repository has become a Cargo workspace. The new
crates
directory contains:dfpp
: PDG generation, same as beforedfpp-explorer
: thedfpp/explorer
directory factored into a standalone cratedfgraph
: the coreProgramDescription
type emitted bydfpp
dfcheck
: the runtime for property checkersI also added a
props
directory at the root which contains sample implementations of properties for Websubmit and Lemmy.Why Does It Need To?
To separate out the different concerns, and to ensure that third-party property checkers don't need to include every
dfpp
transitive dependency.Checklist
good record of what changed.
if necessary
dfcheck
anddfcheck-cli
crates are not documented because their structure is highly tentative.dfcheck-cli
tool on the sample properties.