Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the inline elision tests fail.
Even more mysterious: If I disable elision (not pass the
--inline-elision
argument), only three of them fail.Maybe this is mean to happen, but need to investigate. Already found one niche (but very dumb) error in the algebra.
So here is what happened.
--inline-elision
was no longer being heeded. Inline elision would simply always be performed. Worse still it would also forget to check if the function carries a marker in the inliner. This might not actually have manifested negatively but it feels dangerous at least.std::convert::identity
(an external function and therefore neither inlined, nor elided) inside and then check if that function is in the graph.Now the test cases predictably succeed when
--inline-elision
is active and fail if not.