Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes found when experimenting with Lemmy #166

Merged
merged 20 commits into from
Sep 9, 2024
Merged

Conversation

JustusAdam
Copy link
Collaborator

@JustusAdam JustusAdam commented Aug 30, 2024

What Changed?

This PR contains a series of fixes for bugs in new features found when using the new Paralegal version on an unhacked Lemmy.

  • Support fn's in sub-closure stubs
  • Adds strategic overtaint for stubs to avoid crashes and to recognize that the return value isn't used exactly as returned from the closure. The type of overtaint is a loss of field level precision.
  • External markers, the build config as well as the include and analyze argument now contribute to the hash used to control recompilation
  • Added handling for InstanceDef::FnOnceShim
  • Renames flow-models to stubs
  • Applies stubs in marker discovery
  • Fixes ordering of shortest_path
  • Ensure we check marker reachability in non-crate-local functions too.

Why Does It Need To?

Fixes bugs.

Makes the names consistent. What we called "flow models" here are more like stubs.

Checklist

  • Fix shortest_path ordering
  • Above description has been filled out so that upon quash merge we have a
    good record of what changed.
  • New functions, methods, types are documented. Old documentation is updated
    if necessary
  • Documentation in Notion has been updated
  • Tests for new behaviors are provided
    • New test suites (if any) ave been added to the CI tests (in
      .github/workflows/rust.yml) either as compiler test or integration test.
      Or justification for their omission from CI has been provided in this PR
      description.

@JustusAdam JustusAdam marked this pull request as ready for review September 9, 2024 15:30
@JustusAdam JustusAdam merged commit c52fc5c into main Sep 9, 2024
4 checks passed
@JustusAdam JustusAdam deleted the lemmy-experiment branch November 21, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant