Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling for poll calls to non-generator futures #161

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

JustusAdam
Copy link
Collaborator

@JustusAdam JustusAdam commented Jul 23, 2024

What Changed?

No longer attempts to use the "resolve original arguments" kind of async handling on futures that have explicit poll implementations, as opposed to being auto-implemented (e.g. async fn and async blocks).

Removes a loop in async arg resolution, as it was no longer exercised.

Why Does It Need To?

Avoids spurious errors in trying to resolve async arguments.

Fixes #159

Checklist

  • Above description has been filled out so that upon quash merge we have a
    good record of what changed.
  • New functions, methods, types are documented. Old documentation is updated
    if necessary
  • Documentation in Notion has been updated
  • Tests for new behaviors are provided
    • New test suites (if any) ave been added to the CI tests (in
      .github/workflows/rust.yml) either as compiler test or integration test.
      Or justification for their omission from CI has been provided in this PR
      description.

@JustusAdam JustusAdam changed the title Fix handling for poll calls to no-closure futures Fix handling for poll calls to non-generator futures Jul 23, 2024
@JustusAdam JustusAdam merged commit d53df7e into main Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async handling code tries to treat structs that implement Future as async fn results
1 participant