-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty printing of source code locations #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Adds diagnostic facilities for printing the source code spans corresponding to nodes in the SPDG to
paralegal-policy
.These facilities were mainly created by @MithiJ and @nharbiso. I made some minor changes to it:
CallSiteSpan
because only theloc
field seemed to be usedSrcCodeInfo
and thesrc_locs
field and instead attached the spans directly as part of node weights.This uses some trickery based from the subtle relationships between the spans of a local variable and that of an instruction. Specifically we record both the instruction span and the spans of the definition sites of local variables. In most cases the operators to an instruction, especially for function calls, are temporary local variables that are automatically generated by the rust compiler. The spans of their definition site is precisely the span of an argument. We exploit this "coincidence" by printing the entire span of the instruction, but highlight only the definition span of the local, which happens to be the area of the argument we care about. If the definition span does not lie within the span of the instruction we print only the instruction and highlight everything.
Why Does It Need To?
Improves the UI for users and policy developers.
Checklist
good record of what changed.
if necessary
.github/workflows/rust.yml
) either as compiler test or integration test.Or justification for their omission from CI has been provided in this PR
description.