fix: live admin page authenticates with github #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broarr
requested changes
Aug 20, 2024
api/_lib/oauth2.ts
Outdated
There was a problem hiding this comment.
We can probably move this code into the src directory. I think this folder was left over from the next template
Comment on lines
+12
to
+16
| output: "hybrid", | ||
| integrations: [mdx(), sitemap(), tailwind(), react()], | ||
| adapter: node({ | ||
| mode: "standalone" | ||
| }) |
api/_lib/oauth2.ts
Outdated
Comment on lines
17
to
29
| <script> | ||
| const receiveMessage = (message) => { | ||
| window.opener.postMessage( | ||
| 'authorization:github:${status}:${JSON.stringify(content)}', | ||
| message.origin | ||
| ); | ||
|
|
||
| window.removeEventListener("message", receiveMessage, false); | ||
| } | ||
| window.addEventListener("message", receiveMessage, false); | ||
|
|
||
| window.opener.postMessage("authorizing:github", "*"); | ||
| </script> |
There was a problem hiding this comment.
I think this needs to go in the auth.astro page
| @@ -14,6 +14,7 @@ | |||
| "dependencies": { | |||
| "@astrojs/check": "^0.5.3", | |||
| "@astrojs/mdx": "^2.1.1", | |||
| "@astrojs/node": "^8.3.3", | |||
There was a problem hiding this comment.
Astro requires an ssr adapter in order to enable server side rendering : https://docs.astro.build/en/guides/server-side-rendering
Comment on lines
+7
to
+8
|
|
||
| <Layout title="Authenticate" description="" /> |
There was a problem hiding this comment.
Do you need this if the thing is calling GET?
|
Visit the preview URL for this PR (updated for commit cc272aa): https://mmp-site-b1c9b--pr87-github-oauth-lg93rgk4.web.app (expires Thu, 12 Sep 2024 18:44:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.