Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pubs page styling #70

Merged
merged 2 commits into from
Jul 15, 2024
Merged

feat: pubs page styling #70

merged 2 commits into from
Jul 15, 2024

Conversation

galenwinsor
Copy link
Collaborator

No description provided.

@galenwinsor galenwinsor requested a review from hetd54 July 2, 2024 22:02
@galenwinsor galenwinsor self-assigned this Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Visit the preview URL for this PR (updated for commit 6f8ed9b):

https://mmp-site-b1c9b--pr70-feat-pubs-styling-y6latixc.web.app

(expires Mon, 22 Jul 2024 14:31:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

src/components/Textarea.tsx Outdated Show resolved Hide resolved
src/components/Input.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@hetd54 hetd54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments!

Separately, what are your thoughts about having a "No [Category] Found" within each pub section when there aren't any returned pubs?

@galenwinsor
Copy link
Collaborator Author

Separately, what are your thoughts about having a "No [Category] Found" within each pub section when there aren't any returned pubs?

Sounds good to me!

@hetd54 hetd54 self-requested a review July 15, 2024 14:43
@hetd54 hetd54 merged commit ee53cc0 into main Jul 15, 2024
2 checks passed
@hetd54 hetd54 deleted the feat-pubs-styling branch July 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants