Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat map page #46

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Feat map page #46

merged 6 commits into from
Jun 17, 2024

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Jun 11, 2024

Until we meet with David to see what data and interest he has in an interactive map, I've put the static image of the map from the old site.

Added

Files

Image of MMP map

Components

svg/Arrow.tsx : An arrow svg that I use as a button in a link to the documentation page at the bottom of the Map page.

Layouts

Home.astro: made this alternate layout specifically for the home page, which has a lede with extra spacing

Pages

map.astro: the map page

Questions for reviewers

I am on the fence about what information is included here vs. the documentation page. On the old site, OPR has:

Study Design
Sample Design
Selecting Communities
Ethnosurvey
Interview Process
Data Coding / Weights

I have the general "Study Design" page information on here since the documentation page is going to be MASSIVE otherwise. What do you think -- should we ask David what information is important to include on the site?

Is the method I used of "Read the Documentation" with the svg button accessible?

@hetd54 hetd54 self-assigned this Jun 11, 2024
Copy link

github-actions bot commented Jun 11, 2024

Visit the preview URL for this PR (updated for commit fd13905):

https://mmp-site-b1c9b--pr46-feat-map-page-b49ke3nf.web.app

(expires Mon, 24 Jun 2024 14:33:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

Copy link
Contributor

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me for now! In response to your question: I think this is fine for now. I would change the "read more" link to include the text as well, and remove the role="button".

src/pages/map.astro Outdated Show resolved Hide resolved
@broarr
Copy link

broarr commented Jun 13, 2024

This all looks great. I have the same comment as @galenwinsor

@hetd54 hetd54 requested a review from galenwinsor June 13, 2024 14:53
Copy link
Contributor

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (let's gamble, try merging)

@hetd54 hetd54 merged commit 60783b8 into main Jun 17, 2024
2 checks passed
@hetd54 hetd54 deleted the feat-map-page branch June 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants