-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase initialization #30
Conversation
Visit the preview URL for this PR (updated for commit b681ba6): https://mmp-site-b1c9b--pr30-firebase-initializat-hw1lssse.web.app (expires Tue, 05 Mar 2024 22:03:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i have a few questions but they mostly come down to me (a) not understanding the project and (b) me not understanding next js.
great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Could you initialize the emulators too? It'll make your life a lot easier later!
I think maybe getting hosting working too would be great. Here's some docs on integrating next.js with firebase |
change stack to astro with static cms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, some of this feels like duplicates from the previous PR. Also, I think we're just using firebase hosting for now. Lets add stuff when we have a need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you wanna use our @brown-ccv/eslint-config, or leave it as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoooore! 👯 Added it :)
…v/mmp into firebase-initialization
No description provided.