Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase initialization #30

Closed
wants to merge 26 commits into from
Closed

Firebase initialization #30

wants to merge 26 commits into from

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Jan 16, 2024

No description provided.

Copy link

github-actions bot commented Jan 16, 2024

Visit the preview URL for this PR (updated for commit b681ba6):

https://mmp-site-b1c9b--pr30-firebase-initializat-hw1lssse.web.app

(expires Tue, 05 Mar 2024 22:03:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

@hetd54 hetd54 marked this pull request as ready for review January 16, 2024 22:08
@hetd54 hetd54 linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link
Collaborator

@anna-murphy anna-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i have a few questions but they mostly come down to me (a) not understanding the project and (b) me not understanding next js.

great work!

firebase.json Show resolved Hide resolved
public/index.html Show resolved Hide resolved
Copy link

@broarr broarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Could you initialize the emulators too? It'll make your life a lot easier later!

firebase.json Show resolved Hide resolved
public/index.html Show resolved Hide resolved
@broarr
Copy link

broarr commented Jan 17, 2024

I think maybe getting hosting working too would be great. Here's some docs on integrating next.js with firebase

https://firebase.google.com/docs/hosting/frameworks/nextjs

Copy link

@broarr broarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, some of this feels like duplicates from the previous PR. Also, I think we're just using firebase hosting for now. Lets add stuff when we have a need

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna use our @brown-ccv/eslint-config, or leave it as is?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoooore! 👯 Added it :)

firestore.rules Outdated Show resolved Hide resolved
functions/.eslintrc.js Outdated Show resolved Hide resolved
@hetd54 hetd54 closed this Feb 27, 2024
@hetd54 hetd54 deleted the firebase-initialization branch February 27, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to Firebase
3 participants