Merge pull request #49 from brown-ccv/fix-storybook-chart

fix: handle non-existant div in storybook
brown-ccv · Jan 21, 2021 · 7b578c6 · 7b578c6
2 parents a2e42a7 + 3fcf5d4
commit 7b578c6
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/mixins/vega-base-mixin.js b/src/mixins/vega-base-mixin.js
@@ -100,18 +100,21 @@ const vegaBaseMixin = {
       parentElement: null,
     };
   },
-  mounted() {
+  created() {
     // add random number to id to ensure uniqueness - important for storybook
     this.fullId = this.id + Math.floor(Math.random() * Math.floor(1000));
-
+  },
+  mounted() {
     this.$nextTick(() => {
       const el = document.querySelector('#' + this.fullId);
-      this.parentElement = el.parentElement;
+      if (el) {
+        this.parentElement = el.parentElement;
 
-      this.updatePlot();
+        this.updatePlot();
 
-      this.resizeObserver = new ResizeObserver(this.resizePlot);
-      this.resizeObserver.observe(this.parentElement);
+        this.resizeObserver = new ResizeObserver(this.resizePlot);
+        this.resizeObserver.observe(this.parentElement);
+      }
     });
   },
   beforeDestory() {