Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elokoyi to people #277

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Add elokoyi to people #277

merged 8 commits into from
Jun 25, 2024

Conversation

elokoyi1989
Copy link
Contributor

No description provided.

@elokoyi1989 elokoyi1989 changed the title Add elokoyi to people Add elokoyi images Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Visit the preview URL for this PR (updated for commit 7be9095):

https://ccv-brown-edu--pr277-add-elokoyi-to-peopl-s32vq8ji.web.app

(expires Mon, 01 Jul 2024 16:57:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@elokoyi1989 elokoyi1989 changed the title Add elokoyi images Add elokoyi to people Jun 14, 2024
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images in the preview aren't showing up! Love your bio!!!

A few changes to go :)

about/people.yml Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to convert this image to a .jpg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to convert this to a .jpg

eldu
eldu previously requested changes Jun 17, 2024
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like your images are still not showing up in the preview.

In your image names, you have Elizabeth_main.jpg and Elizabeth_hover.jpg. You'll need to make that Elizabeth lowercase to match what you have in the yaml file

So close !!!

@elokoyi1989 elokoyi1989 requested a review from eldu June 18, 2024 19:25
@elokoyi1989 elokoyi1989 reopened this Jun 24, 2024
Copy link
Contributor Author

@elokoyi1989 elokoyi1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I have fixed all the resuested changes fingers crossed

@elokoyi1989 elokoyi1989 dismissed eldu’s stale review June 24, 2024 17:01

made requested edits

Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Let's merge it in :)

@elokoyi1989 elokoyi1989 merged commit c99ac4c into main Jun 25, 2024
12 checks passed
@elokoyi1989 elokoyi1989 deleted the add-elokoyi-to-people branch June 25, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants