-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elokoyi to people #277
Conversation
Visit the preview URL for this PR (updated for commit 7be9095): https://ccv-brown-edu--pr277-add-elokoyi-to-peopl-s32vq8ji.web.app (expires Mon, 01 Jul 2024 16:57:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images in the preview aren't showing up! Love your bio!!!
A few changes to go :)
images/people/Elizabeth_hover.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to convert this image to a .jpg
images/people/Elizabeth_main.jpeg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to convert this to a .jpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, looks like your images are still not showing up in the preview.
In your image names, you have Elizabeth_main.jpg
and Elizabeth_hover.jpg
. You'll need to make that Elizabeth lowercase to match what you have in the yaml file
So close !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I have fixed all the resuested changes fingers crossed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Let's merge it in :)
No description provided.