Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new pull request to add michelange #273

Merged
merged 13 commits into from
Jun 20, 2024
Merged

new pull request to add michelange #273

merged 13 commits into from
Jun 20, 2024

Conversation

mickey0116
Copy link
Contributor

No description provided.

@mickey0116 mickey0116 requested review from eldu and broarr June 11, 2024 14:35
Copy link

github-actions bot commented Jun 11, 2024

Visit the preview URL for this PR (updated for commit f833263):

https://ccv-brown-edu--pr273-michelange-senat-1my1uohj.web.app

(expires Tue, 25 Jun 2024 15:12:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of the yaml looks good and the images too! I made some comments on typos and work changes. Looks like you've replaced Jesus! So let's bring him back into the website.

Looks good so far though !

about/people.yml Show resolved Hide resolved
about/people.yml Outdated Show resolved Hide resolved
about/people.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@mickey0116 mickey0116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added Jesus back and fixed my errors

about/people.yml Outdated Show resolved Hide resolved
@broarr
Copy link
Contributor

broarr commented Jun 13, 2024

Looks great after your revisions! One little typo and I think we're good to merge!

@broarr
Copy link
Contributor

broarr commented Jun 13, 2024

You'll have to merge main in and resolve the conflicts. Let me know if you'd like help with that

Copy link
Contributor

@broarr broarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🎉

Copy link
Contributor Author

@mickey0116 mickey0116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!! Merge it in when you get the chance :)

@mickey0116 mickey0116 merged commit 2283a79 into main Jun 20, 2024
12 checks passed
@mickey0116 mickey0116 deleted the michelange-senat branch June 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants