Add Marwan to website #264
Conversation
|
Visit the preview URL for this PR (updated for commit a3a32bb): https://ccv-brown-edu--pr264-add-marwan-to-websit-nxv6n2zn.web.app (expires Mon, 24 Jun 2024 15:14:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
about/people.yml
Outdated
| github_username: marwanali55 | ||
| brown_directory_uuid: 80e72ea3-bce9-4685-bc2c-3041b55facfc | ||
| bio: Marwan is a summer intern working with the Computational Biology Core at CCV. He is an undergraduate student studying Applied Mathematics. He loves reading, playing piano, and writing stand-up comedy. | ||
| image: marwan_main.PNG |
There was a problem hiding this comment.
This says the image will be a png file, but the images are jpgs. Take a look at the preview link (in a comment on the PR) and try to debug why your profile picture isn't showing up!
There was a problem hiding this comment.
Hi Ellen! Sorry about that; I just updated it to marwan_main.jpg. Please let me know if there are any other issues.
Updated PNG to JPG
images/people/marwan_hover.JPG
Outdated
There was a problem hiding this comment.
Just one last thing: you need to make the jpg in this file lowercase to match marwan_main. Love the photo!
There was a problem hiding this comment.
Thanks for letting me know Galen, I just made the change. Please reach out if anything else is needed.
|
@marwanali55 I went ahead and fixed the merge conflicts; once the checks run and pass, feel free to merge! |
Added my description and images.