-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add Michael Tu to team site #249
Feat: add Michael Tu to team site #249
Conversation
Changed the image file name in attempt to pass the build_and_preview test on Github
build_and_preview test might be failing because my branch is on a forked repo. I had to fork it because I don't write access to this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeltu01 I think your main image is an invalid format that is why the test is failing. Could you update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The preview error is due to your local fork not having permissions. You should have write access, so I'd recommend creating an issue and pr from that in this repo.
@thehalfspace I made a new pr in this repo #252 , where the branch is resides in this repo. It should be able to merge. |
Closing this, it is done in PR #252 |
Michael Tu is a new data science intern at CCV. He is adding his bio to the team site.