Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add Michael Tu to team site #249

Closed

Conversation

michaeltu01
Copy link
Contributor

Michael Tu is a new data science intern at CCV. He is adding his bio to the team site.

@michaeltu01 michaeltu01 requested a review from thehalfspace June 4, 2024 17:17
Changed the image file name in attempt to pass the build_and_preview test on Github
@michaeltu01
Copy link
Contributor Author

build_and_preview test might be failing because my branch is on a forked repo. I had to fork it because I don't write access to this repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeltu01 I think your main image is an invalid format that is why the test is failing. Could you update this?

Copy link
Contributor

@thehalfspace thehalfspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The preview error is due to your local fork not having permissions. You should have write access, so I'd recommend creating an issue and pr from that in this repo.

@michaeltu01
Copy link
Contributor Author

@thehalfspace I made a new pr in this repo #252 , where the branch is resides in this repo. It should be able to merge.

@thehalfspace
Copy link
Contributor

Closing this, it is done in PR #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants