Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cartesian join bug #104

Merged
merged 11 commits into from
Mar 21, 2022
Merged

Fix cartesian join bug #104

merged 11 commits into from
Mar 21, 2022

Conversation

alanmcruickshank
Copy link
Contributor

This resolves #103 . The right granularity in these tables in command_invocation_id regardless of whether in cloud or local.

@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 10, 2022 15:49 Failure
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 10, 2022 15:49 Failure
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 12, 2022 08:04 Failure
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 12, 2022 08:04 Failure
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 13, 2022 21:04 Failure
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 13, 2022 21:04 Failure
@alanmcruickshank
Copy link
Contributor Author

@NiallRees - this is ready for re-review. It should now:

  • Dedupe V2 manifests on upload.
  • Dedupe V1 manifests on read.
  • Join exclusively on artifact_run_id in later models.

@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 14, 2022 09:55 Inactive
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 14, 2022 09:55 Failure
@NiallRees NiallRees had a problem deploying to Approve Integration Tests March 14, 2022 10:05 Failure
@NiallRees NiallRees temporarily deployed to Approve Integration Tests March 14, 2022 10:05 Inactive
@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 14, 2022 10:59 Inactive
@alanmcruickshank alanmcruickshank had a problem deploying to Approve Integration Tests March 14, 2022 10:59 Failure
@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 14, 2022 11:05 Inactive
@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 14, 2022 11:05 Inactive
@NiallRees
Copy link
Contributor

Looks like there are a couple of linting errors but everything else is working now @alanmcruickshank

@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 20, 2022 15:50 Inactive
@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 20, 2022 15:50 Inactive
@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 20, 2022 20:57 Inactive
@alanmcruickshank alanmcruickshank temporarily deployed to Approve Integration Tests March 20, 2022 20:57 Inactive
@NiallRees NiallRees merged commit ea64592 into brooklyn-data:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiallRees NiallRees NiallRees left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor of granularity in tables.
2 participants
@alanmcruickshank @NiallRees