Add transforms for legacy IE https://github.com/Rezonans/redux-async-…

[badtant]

Lib failed in IE10 and these babel plugins were needed.

[pmark]

This resolved the issue for me, but "loose" should be wrapped in double quotes.

[pmark]

Looking forward to this being released ;)

[badtant]

Me too, seems like development on v1 has stopped :(

[ratson]

@sars Is what @badtant said is true?

[Iuriy-Budnikov]

When will be release?

[dawidvdh]

Really need this fix for a production project.

[Iuriy-Budnikov]

@sars

[pmark]

Just pull all the code into your project until it's released.

On Friday, April 15, 2016, Dawid van der Hoven [email protected]
wrote:

Really need this fix for a production project.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#64 (comment)

[Iuriy-Budnikov]

Pulled. It doesn't work :)

[pmark]

This works for me:

1. Clone the repo
2. Build it (npm run build)
3. Copy lib/ into my project as a subfolder named redux-async-connect
4. Import redux-async-connect with a relative path

Works in IE9+ and other real browsers.

[Iuriy-Budnikov]

Yeah, I made monkey patching. But got an error.

[Iuriy-Budnikov]

[pmark]

Can you confirm that you ran "npm run build" from the redux-async-connect folder itself? Running your project's build script will not honor the .babelrc file in the redux-async-connect folder.

[Iuriy-Budnikov]

Can you confirm that you ran "npm run build" from the redux-async-connect folder itself? Running your project's build script will not honor the .babelrc file in the redux-async-connect folder.

Sure :)

[Iuriy-Budnikov]

I did npm run build in new folder redux-async-connect

[pmark]

OK now I see what's going on:

• The proto error will appear when using hot module reload (for development only) in IE because of how react-proxy is implemented.
• Try testing IE in with the production environment, which is what ultimately matters.
• Forget what I said about building redux-async-connect separately from your project. You can add the transform-class-properties and transform-es2015-classes plugins to your main project's .babelrc file.

[Iuriy-Budnikov]

Here my config

{
  "presets": ["react", "es2015", "stage-0"],

  "plugins": [
    "transform-runtime",
    "add-module-exports",
    "transform-decorators-legacy",
    "transform-react-display-name",
    "transform-class-properties",
    "transform-es2015-classes"
  ],

  "env": {
    "development": {
      "plugins": [
        "typecheck",
        ["react-transform", {
            "transforms": [{
                "transform": "react-transform-catch-errors",
                "imports": ["react", "redbox-react"]
              }
            ]
        }]
      ]
    }
  }
}

I tested with production. The same error.

[Iuriy-Budnikov]

with ["transform-es2015-classes", {"loose": true}] the same.

[pmark]

Do you think that something else is using react-proxy?

[pmark]

Did you start with react-redux-universal-hot-example?

[Iuriy-Budnikov]

Did you start with react-redux-universal-hot-example?

Exactly.

[pmark]

I wish I could help more, but I can confirm that the problem was resolved for me when I added those transforms and tested IE without HMR.

[Iuriy-Budnikov]

@pmark thanks, for your help. Could you check the same with react-redux-universal-hot-example?

[Iuriy-Budnikov]

I can share my repo

[hanzhao]

I really need this PR for a project, too. 😢

[dtuyenle]

:_( Is this pushed to the latest release ? I really need this for prod

[snowcxt]

need this for prod too

[hanzhao]

@snowcxt Hi. I switch to makeomatic/redux-connect now to make my code work for prod. Maybe it helps.