[CORE-307] Fix Spend Report Visibility for Billing Project Users (Workspace Owners) #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinmarete
requested review from
dvoet and
davidangb
and removed request for
a team
dvoet
requested changes
Feb 21, 2025
| @@ -477,7 +477,9 @@ class SpendReportingService( | |||
| aggregations: Set[SpendReportingAggregationKeyWithSub] | |||
| ): Future[SpendReportingResults] = { | |||
| validateReportParameters(start, end) | |||
| requireProjectAction(project, SamBillingProjectActions.readSpendReport) { | |||
| requireProjectAction(project, | |||
| SamBillingProjectActions.createWorkspace | |||
There was a problem hiding this comment.
readSpendReport sounds like the right action to be checking. This probably should be a sam config change to grant readSpendReport to the right workspace role.
There was a problem hiding this comment.
reading the jira more closely, it sounds like we have some inconsistent permission checking. Here, we are checking a project action but in the consolidated spend report it is perhaps checking a workspace action? We should make the permission checks consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CORE-307
This PR ensures that Billing Project Users can view spend reports for workspaces they own on the billing project workspaces list page. Previously, these costs appeared as N/A, and users would receive a
403 Forbidden errorwhen attempting to access the billing project spend report. This was due to the requireProjectAction check forreadSpendReport, which was restricted to project owners. I have updated this tocreateWorkspace, allowing workspace owners to access spend reports across all billing projects.Before
After
PR checklist
model/, then you should publish a new officialrawls-modeland perform the corresponding dependency updates as specified in the README: