-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOR-1690] Update mysql-connector-j from 8.4.0 to 9.0.0 #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
changed the title
Update mysql-connector-j from 8.4.0 to 9.0.0
NEEDS INVESTIGATION, Update mysql-connector-j from 8.4.0 to 9.0.0
Aug 6, 2024
marctalbott
reviewed
Aug 16, 2024
@@ -78,7 +78,8 @@ object Dependencies { | |||
val ficus: ModuleID = "com.iheart" %% "ficus" % "1.5.2" | |||
val apacheCommonsIO: ModuleID = "commons-io" % "commons-io" % "2.16.1" | |||
val antlrParser: ModuleID = "org.antlr" % "antlr4-runtime" % "4.13.2" | |||
val mysqlConnector: ModuleID = "com.mysql" % "mysql-connector-j" % "8.4.0" | |||
// protobuf is only need to use the MySQL X DevAPI which we don't. exclude it to avoid interference with Google client libraries | |||
val mysqlConnector: ModuleID = "com.mysql" % "mysql-connector-j" % "9.0.0" exclude("com.google.protobuf", "protobuf-java") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the mysql-connector-j
readme
if you do not use the X DevAPI features, you may also want to add a dependency exclusion to avoid linking [protobuf-java]
My scalafmt does not agree with the failing GHA check |
marctalbott
changed the title
NEEDS INVESTIGATION, Update mysql-connector-j from 8.4.0 to 9.0.0
[WOR-1690] Update mysql-connector-j from 8.4.0 to 9.0.0
Aug 16, 2024
marctalbott
requested review from
a team,
marctalbott and
aherbst-broad
and removed request for
a team
August 16, 2024 20:21
marctalbott
approved these changes
Aug 16, 2024
aherbst-broad
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
π¦ Updates com.mysql:mysql-connector-j from
8.4.0
to9.0.0
βπ GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: