Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-1690] Update mysql-connector-j from 8.4.0 to 9.0.0 #2944

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

broadbot
Copy link
Contributor

@broadbot broadbot commented Jul 8, 2024

About this PR

πŸ“¦ Updates com.mysql:mysql-connector-j from 8.4.0 to 9.0.0 ⚠

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.mysql", artifactId = "mysql-connector-j" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.mysql", artifactId = "mysql-connector-j" }
}]
labels: library-update, early-semver-major, semver-spec-major, commit-count:1

@github-actions github-actions bot added the Scala_Steward Scala Steward label Jul 8, 2024
@cahrens cahrens marked this pull request as draft August 6, 2024 13:22
@cahrens cahrens changed the title Update mysql-connector-j from 8.4.0 to 9.0.0 NEEDS INVESTIGATION, Update mysql-connector-j from 8.4.0 to 9.0.0 Aug 6, 2024
@@ -78,7 +78,8 @@ object Dependencies {
val ficus: ModuleID = "com.iheart" %% "ficus" % "1.5.2"
val apacheCommonsIO: ModuleID = "commons-io" % "commons-io" % "2.16.1"
val antlrParser: ModuleID = "org.antlr" % "antlr4-runtime" % "4.13.2"
val mysqlConnector: ModuleID = "com.mysql" % "mysql-connector-j" % "8.4.0"
// protobuf is only need to use the MySQL X DevAPI which we don't. exclude it to avoid interference with Google client libraries
val mysqlConnector: ModuleID = "com.mysql" % "mysql-connector-j" % "9.0.0" exclude("com.google.protobuf", "protobuf-java")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the mysql-connector-j readme

if you do not use the X DevAPI features, you may also want to add a dependency exclusion to avoid linking [protobuf-java]

@marctalbott
Copy link
Contributor

marctalbott commented Aug 16, 2024

My scalafmt does not agree with the failing GHA check

@marctalbott marctalbott changed the title NEEDS INVESTIGATION, Update mysql-connector-j from 8.4.0 to 9.0.0 [WOR-1690] Update mysql-connector-j from 8.4.0 to 9.0.0 Aug 16, 2024
@marctalbott marctalbott marked this pull request as ready for review August 16, 2024 20:21
@marctalbott marctalbott requested review from a team, marctalbott and aherbst-broad and removed request for a team August 16, 2024 20:21
@marctalbott marctalbott merged commit ec4a307 into develop Aug 19, 2024
29 checks passed
@marctalbott marctalbott deleted the update/mysql-connector-j-9.0.0 branch August 19, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scala_Steward Scala Steward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants