Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-1099] Update liquibase-core from 4.17.2 to 4.23.0 #2428

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

broadbot
Copy link
Contributor

@broadbot broadbot commented Jul 3, 2023

About this PR

📦 Updates org.liquibase:liquibase-core from 4.17.2 to 4.23.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.liquibase", artifactId = "liquibase-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.liquibase", artifactId = "liquibase-core" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@cahrens
Copy link
Contributor

cahrens commented Jul 5, 2023

jenkins retest

@cahrens cahrens changed the title Update liquibase-core from 4.17.2 to 4.23.0 [WOR-1099] Update liquibase-core from 4.17.2 to 4.23.0 Jul 5, 2023
@cahrens cahrens marked this pull request as draft July 5, 2023 14:07
@cahrens
Copy link
Contributor

cahrens commented Jul 5, 2023

Liquibase is complaining about things that it did not care about in the past (duplicate identifiers). Created WOR-1099 to investigate/fix.

@broadbot broadbot changed the title [WOR-1099] Update liquibase-core from 4.17.2 to 4.23.0 Update liquibase-core from 4.17.2 to 4.23.0 Aug 1, 2023
@cahrens cahrens changed the title Update liquibase-core from 4.17.2 to 4.23.0 [WOR-1099] Update liquibase-core from 4.17.2 to 4.23.0 Aug 11, 2023
@cahrens cahrens force-pushed the update/liquibase-core-4.23.0 branch from 0d58804 to 9a1e755 Compare August 11, 2023 18:59
@@ -88,10 +88,6 @@
<include file="changesets/20201106_workspace_google_project_columns.xml" relativeToChangelogFile="true"/>
<include file="changesets/20201113_add_billing_account_workspace.xml" relativeToChangelogFile="true"/>
<include file="changesets/20210430_add_workspace_billing_account_error_message.xml" relativeToChangelogFile="true"/>
<include file="changesets/20210524_add_memory_retry_multiplier.xml" relativeToChangelogFile="true"/>
Copy link
Contributor

@cahrens cahrens Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are duplicated above at lines 83-86, I assume due to a bad merge conflict. The newer versions of liquibase started erroring on this. The IDs it prints are from the changesets within these 4 files.

[error] Caused by: liquibase.exception.ValidationFailedException: Validation Failed:
[error]      8 changesets had duplicate identifiers
[error]           dummy::add_billing_project_export_table_column::mbemis
[error]           dummy::add_memory_retry::cjllanwarne
[error]           dummy::REMOVE_WORKSPACE_ATTRIBUTE_SCRATCH::dhite
[error]           dummy::drop_workspace_attr_temp_table::dhite
[error]           dummy::add_billing_project_export_google_project_column::mbemis
[error]           dummy::add_billing_project_export_dataset_column::mbemis
[error]           dummy::create_workspace_attr_temp_table::dhite
[error]           dummy::create_workspace_attr_temp_table_revised::dhite

@cahrens cahrens marked this pull request as ready for review August 11, 2023 19:16
@cahrens cahrens requested review from a team, cahrens, marctalbott, aherbst-broad and blakery and removed request for a team August 11, 2023 19:17
@cahrens cahrens merged commit ca8c215 into develop Aug 11, 2023
12 checks passed
@cahrens cahrens deleted the update/liquibase-core-4.23.0 branch August 11, 2023 19:53
blakery added a commit that referenced this pull request Aug 14, 2023
blakery added a commit that referenced this pull request Aug 14, 2023
@broadbot
Copy link
Contributor Author

Superseded by #2539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scala_Steward Scala Steward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants