Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remainder of BPM consumer test points (WOR-908). #2420

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

cahrens
Copy link
Contributor

@cahrens cahrens commented Jun 29, 2023

Ticket: https://broadworkbench.atlassian.net/browse/WOR-908

"Can I deploy" will fail until DataBiosphere/terra-billing-profile-manager#240 is merged, but I promise that the contractor verification test passes when I run it locally.

image


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@cahrens
Copy link
Contributor Author

cahrens commented Jun 29, 2023

@ichengchang "can I deploy" should have failed because this PR contains new consumer tests and the BPM side hasn't yet merged… but oddly it passed! It appears that "can I deploy" is getting mixed up on which run it relates to because when I go to the details, it says this is a drshub/cromwell pact, not a rawls/BPM pact.

This mixup of actions could also be why we are seeing incorrect failures about no pacts being present.

CONSUMER          | C.VERSION  | PROVIDER        | P.VERSION  | SUCCESS? | RESULT#
------------------|------------|-----------------|------------|----------|--------
cromwell-consumer | f9511a1... | drshub-provider | fec1729... | true     | 1      

VERIFICATION RESULTS
--------------------
1. https://pact-broker.dsp-eng-tools.broadinstitute.org/pacts/provider/drshub-provider/consumer/cromwell-consumer/pact-version/e915b74e23b934b6f86e5f65e1cf0895b9f9d831/metadata/Y3ZuPWY5NTExYTE3MDk5ZmYzNjRmMjJlNTU3NWYxNDQ5MjdjOTA5NGY2Mjk/verification-results/998 (success)

@cahrens cahrens merged commit 88f2137 into develop Jun 30, 2023
13 checks passed
@cahrens cahrens deleted the WOR-908-again branch June 30, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants