Skip to content

Commit

Permalink
v0.16.35 (#181)
Browse files Browse the repository at this point in the history
Hotfix: mop was failing for Python 2.7 installations when the user didn't set a default project, and the bucket listing error message was broken. To fix this, bucket listing was updated to use the workspace billing project, and the bucket listing exception catching code was corrected.
  • Loading branch information
dheiman committed Sep 27, 2022
1 parent 95e03f1 commit 0cb8dbb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
8 changes: 6 additions & 2 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
=======================================================================
================================================================================
Change Log for FISSFC: the (Fi)recloud (S)ervice (S)elector
=======================================================================
================================================================================
Terms used below: HL = high level interface, LL = low level interface

v0.16.35 - Hotfix: mop returned errors in Python 2 when trying to read the
workspace bucket - bucket listing updated to use the workspace
billing project, and the error report was cleaned up.

v0.16.34 - Hotfixes: in Python 2 map() returns a list, in Python 3, map()
returns a generator object - tasks that returned map(f(x),iterable)
now return a list comprehension; clock-skew now checks for argument
Expand Down
2 changes: 1 addition & 1 deletion firecloud/__about__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Package version
__version__ = "0.16.34"
__version__ = "0.16.35"
4 changes: 2 additions & 2 deletions firecloud/fiss.py
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,7 @@ def list_blob_gen(bucket_name):
Yields:
tuple: File name and the size of the file
"""
client_st = storage.Client()
client_st = storage.Client(project=args.project)
blobs = client_st.list_blobs(bucket_name)
for blob in blobs:
yield ("gs://{}/{}".format(blob.bucket.name, blob.name), int(blob.size))
Expand Down Expand Up @@ -1388,7 +1388,7 @@ def list_blob_gen(bucket_name):

except Exception as e:
eprint("Error retrieving files from bucket:" +
"\n\t{}\n\t{}".format(str(e), e.output))
"\n\t{}: {}".format(type(e).__name__, e))
return 1

if args.verbose:
Expand Down

0 comments on commit 0cb8dbb

Please sign in to comment.