WX-1411 Require preinstalled jq and curl for just-in-time SAS feature
#7350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgainerdewar
reviewed
Jan 3, 2024
| | echo "Error: apt-get is not available, and curl is not installed." | ||
| | exit 1 | ||
| | fi | ||
| | echo "Error: user image must include `jq` for just-in-time SAS token generation, but it is not installed." |
There was a problem hiding this comment.
I think these two error messages need to be reversed.
jgainerdewar
approved these changes
Jan 3, 2024
|
LGTM! I updated this doc to reflect the change here. |
THWiseman
approved these changes
Jan 4, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.