[WX-1774] Push images during PR check using GHA #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest |
salonishah11
changed the title
salonishah11
commented
Sep 24, 2024
Comment on lines
+20
to
+39
| - name: Git secrets setup | ||
| run: | | ||
| git clone https://github.com/awslabs/git-secrets.git ~/git-secrets | ||
| cd ~/git-secrets | ||
| git checkout ad82d68ee924906a0401dfd48de5057731a9bc84 | ||
| sudo make install | ||
| shell: bash | ||
|
|
||
| - name: Secrets check | ||
| run: | | ||
| sudo ln -s "$(which echo)" /usr/local/bin/say | ||
| ./minnie-kenny.sh --force | ||
| git secrets --scan-history | ||
| shell: bash | ||
|
|
||
| - name: Setup JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 |
There was a problem hiding this comment.
This isn't new code. It was already part of renamed docker_build.yml file
jgainerdewar
approved these changes
Sep 24, 2024
aednichols
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://broadworkbench.atlassian.net/browse/WX-1774
This PR updates the build GHA to also
v0.0.Xsimilar to other servicesNote: these changes are only related to build and push GHA for PR checks. There will be a follow up PR to create new GHA that pushes the images and reports the new version to Sherlock when merge to develop happens.
Example GHA run: https://github.com/broadinstitute/agora/actions/runs/11020083532/job/30604056905?pr=341
New tag generated in above run:
v0.0.1-3d4fe7aLink to v0.0.1-3d4fe7a in Dockerhub
Link to v0.0.1-3d4fe7a in GCR