Skip to content

Commit

Permalink
testing
Browse files Browse the repository at this point in the history
  • Loading branch information
salonishah11 committed Sep 25, 2024
1 parent 40c3f6b commit 34ba172
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 5 deletions.
24 changes: 19 additions & 5 deletions .github/workflows/docker_build_and_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
contents: 'read'
id-token: 'write'
outputs:
tag: ${{ steps.tag.outputs.new_tag }}
tag: ${{ steps.tag.outputs.tag }}

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -52,8 +52,8 @@ jobs:
- name: Construct Dockerhub and GCR image names
id: image-name
run: |
echo "DOCKERHUB_NAME=broadinstitute/agora:${{ steps.tag.outputs.new_tag }}" >> $GITHUB_OUTPUT
echo "GCR_NAME=gcr.io/broad-dsp-gcr-public/agora:${{ steps.tag.outputs.new_tag }}" >> $GITHUB_OUTPUT
echo "DOCKERHUB_NAME=broadinstitute/agora:${{ steps.tag.outputs.tag }}" >> $GITHUB_OUTPUT
echo "GCR_NAME=gcr.io/broad-dsp-gcr-public/agora:${{ steps.tag.outputs.tag }}" >> $GITHUB_OUTPUT
- name: Build image
run: |
Expand Down Expand Up @@ -94,8 +94,22 @@ jobs:
uses: broadinstitute/sherlock/.github/workflows/client-report-app-version.yaml@main
needs: [ build-and-push-job ]
with:
new-version: ${{ needs.build-and-push-job.outputs.new_tag }}
new-version: ${{ needs.build-and-push-job.outputs.tag }}
chart-name: 'agora'
permissions:
contents: 'read'
id-token: 'write'
id-token: 'write'

# set-version-in-dev:
# # Put new Agora version in dev environment
# uses: broadinstitute/sherlock/.github/workflows/client-set-environment-app-version.yaml@main
# needs: [ build-and-push-job, report-to-sherlock ]
# if: ${{ github.ref_name == 'develop' }}
# with:
# new-version: ${{ needs.build-and-push-job.outputs.tag }}
# chart-name: 'agora'
# environment-name: 'dev'
# secrets:
# sync-git-token: ${{ secrets.BROADBOT_TOKEN }}
# permissions:
# id-token: 'write'
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ env.properties
*~
.DS_Store
/.bsp/sbt.json

# Ignore generated credentials from google-github-actions/auth
gha-creds-*.json

0 comments on commit 34ba172

Please sign in to comment.