Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom checkpoint location #406

Conversation

edg1983
Copy link

@edg1983 edg1983 commented Jan 14, 2025

Hi.

This pull request introduces a small change to run.py that solves #405 and similar issues.

When the user defines a custom checkpoint location using --checkpoint, if the defined file does not exist, a new checkpoint tarball file is created using the path defined by this option.

In this way, the user can now control the exact location of the checkpoint file when needed instead of the current behavior, where the checkpoint file is always saved to the current working directory.

I've tested this update against the standard 0.3.2 version, and they produced identical results.

@edg1983
Copy link
Author

edg1983 commented Jan 16, 2025

I realized this was already addressed in another pull request (#392). I close this one.

@edg1983 edg1983 closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant