Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat customtools #5

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Feat customtools #5

merged 3 commits into from
Aug 6, 2024

Conversation

matthewgee
Copy link
Member

Description

JIRA ticket

[HIVE-####] <- Replace the pound signs with your JIRA ticket number to have github create a link.

Summary

A summary of the pull request (PR) and the issue it resolves. Please include the following:

  • A link to the relevant issue and/or ClubHouse card
  • A code "walk-through" in bullet points
  • A demo, e.g., screenshots, GIFs, code examples, etc. (OPTIONAL)

Checklists

Basic

  • Did you write tests for the code in this PR?
  • Did you document your changes in the README and/or in docstrings (as needed)?

Security

  • Authorization has been implemented across these changes
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • Any web UI is escaping output (to prevent XSS)
  • Sensitive data has been identified and is being protected properly

Frontend

Notes for the Reviewer

A precise explanation of what the PR reviewer needs to evaluate. This might be:

  • a low-level code review of certain functions
  • a high-level assessment of strategy or architecture
  • a confirmation that the code behaves as expected on another machine

@matthewgee matthewgee requested a review from adrianmf94 August 6, 2024 18:41
Copy link

@adrianmf94 adrianmf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@matthewgee matthewgee merged commit 7b82c9a into develop Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants