Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): arm custom policy support #6769

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

omriyoffe-panw
Copy link
Contributor

@omriyoffe-panw omriyoffe-panw commented Oct 13, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Introduce support for custom ARM policies by enhancing the ArmLocalGraph class to handle explicit and implicit dependencies between resources. Implement the convert_graph_vertices_to_tf_definitions function to convert ARM graph vertices to Terraform definitions. Update the CustomPoliciesIntegration class to register ARM policies, and add test cases to validate the new functionality.

TopicDetails
Graph Conversion Add support for converting ARM graph vertices to Terraform definitions, facilitating integration with Terraform workflows.
Modified files (1)
  • checkov/arm/graph_builder/graph_to_tf_definitions.py
Latest Contributors(0)
EmailCommitDate
Graph Enhancements Implement the ArmLocalGraph class to handle explicit and implicit dependencies between ARM resources, enhancing the graph-building process.
Modified files (2)
  • tests/arm/graph_builder/test_local_graph.py
  • checkov/arm/graph_builder/local_graph.py
Latest Contributors(1)
EmailCommitDate
[email protected]fix-arm-correctly-hand...August 30, 2023
Test Cases Add test cases for ARM resources with explicit dependencies to ensure the correctness of the graph-building process.
Modified files (3)
  • tests/arm/examples/ExplicitDepsResources/storage.json
  • tests/arm/examples/ExplicitDepsResources/interface.json
  • tests/arm/examples/ExplicitDepsResources/subnet.json
Latest Contributors(0)
EmailCommitDate
Policy Integration Register ARM policies in the CustomPoliciesIntegration class, enabling custom policy checks for ARM templates.
Modified files (2)
  • checkov/common/bridgecrew/integration_features/features/custom_policies_integration.py
  • tests/common/integration_features/test_custom_policies_integration.py
Latest Contributors(2)
EmailCommitDate
iifrach@paloaltonetwor...feat-general-Support-m...August 18, 2024
123508988+taviassaf@us...feat-general-support-m...August 05, 2024
This pull request is reviewed by Baz. Join @omriyoffe-panw and the rest of your team on (Baz).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant