Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Add s3 data transport check #6763

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Oct 10, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adds a new check based on Prisma ID: 7b0df373-006a-40d6-9f3d-68e6ea0bdd5d

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Introduce a new check S3SecureDataTransport to ensure AWS S3 buckets are configured with secure data transport policies. This check, identified by CKV_AWS_379, evaluates S3 bucket policies to verify the presence of the aws:SecureTransport condition, ensuring data is transmitted securely. The implementation includes a comprehensive policy evaluation logic and corresponding test cases to validate the check's effectiveness.

TopicDetails
Secure Data Transport Implement the S3SecureDataTransport check to ensure AWS S3 buckets have secure data transport policies.
Modified files (1)
  • checkov/terraform/checks/resource/aws/S3SecureDataTransport.py
Latest Contributors(0)
EmailCommitDate
Test Cases Add test cases to validate the S3SecureDataTransport check functionality.
Modified files (2)
  • tests/terraform/checks/resource/aws/example_S3SecureDataTransport/main.tf
  • tests/terraform/checks/resource/aws/test_S3SecureDataTransport.py
Latest Contributors(0)
EmailCommitDate
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 merged commit 92c23a3 into main Oct 14, 2024
38 of 39 checks passed
@tsmithv11 tsmithv11 deleted the add-s3-data-transport branch October 14, 2024 07:19
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Oct 14, 2024
* Initial steps

* Improve

* Update and add tests

* Fix lint

* Fix dogfood

* Fix flake8 v2
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Oct 14, 2024
* Initial steps

* Improve

* Update and add tests

* Fix lint

* Fix dogfood

* Fix flake8 v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants