Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Ignored --external-modules-download-path flag #6676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apgrucza
Copy link
Contributor

@apgrucza apgrucza commented Aug 22, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes a bug where --external-modules-download-path is ignored.

Fixes #6675

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Fix the handling of the --external-modules-download-path flag in the RunnerRegistry class to ensure it is correctly passed and utilized during the enrichment of Terraform plan reports. Update the get_enriched_resources method to accept and use this flag. Add corresponding tests in test_runner_registry_plan_enrichment.py to verify the correct behavior of the flag.

TopicDetails
Test Enhancements Add tests to verify the correct behavior of the --external-modules-download-path flag in the test_runner_registry_plan_enrichment.py.
Modified files (1)
  • tests/common/runner_registry/test_runner_registry_plan_enrichment.py
Latest Contributors(2)
EmailCommitDate
[email protected]...feat-terraform-Remove-...August 16, 2023
63583491+arielkru@user...feat-terraform-Impleme...December 01, 2022
Flag Handling Fix Fix the handling of the --external-modules-download-path flag in the RunnerRegistry class to ensure it is correctly passed and utilized during the enrichment of Terraform plan reports.
Modified files (1)
  • checkov/common/runners/runner_registry.py
Latest Contributors(2)
EmailCommitDate
[email protected]chore-update-cloudspla...September 18, 2024
47212872+EmmaVinen@use...feat-general-allow-too...September 11, 2024
This pull request is reviewed by Baz. Join @apgrucza and the rest of your team on (Baz).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --external-modules-download-path flag is ignored
1 participant