Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ben, as discussed in the previous PR 13, i hereby present a new PR to make testing use the global postcode formatter.
A few things to note:
getFormatter
functions in the tests and abstract test class obsolete but they have not yet been removed.getCountry
function in the abstract test class using reflection because according to my research this is the easiest and fastest way. However i know that your not a fan of this which is why i am open to suggestions. It was also a fast way of showing you in this PR what i am trying to accomplish. Reflection does however reassure that the formatter has to bo named exactly in the same way as the test and if not, it will all fail.@BenMorel Looking forward to your viewings on this.