Merge pull request #14 from trebi/fix-money-allocate

Money::allocate() fixed bug when Money was negative
brick · Dec 1, 2017 · 178f4ba · 178f4ba
2 parents b983a6d + d6ff383
commit 178f4ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/Money.php b/src/Money.php
@@ -520,6 +520,10 @@ public function allocate(int ...$ratios) : array
         $unit = BigDecimal::ofUnscaledValue($step, $this->amount->getScale());
         $unit = new Money($unit, $this->currency, $this->context);
 
+        if ($this->isNegative()) {
+            $unit = $unit->negated();
+        }
+
         $remainder = $this;
 
         foreach ($ratios as $ratio) {

diff --git a/tests/MoneyTest.php b/tests/MoneyTest.php
@@ -429,6 +429,7 @@ public function providerAllocate()
             [['100.123', 'EUR', new AutoContext()], [2, 3, 1, 1], ['EUR 28.607', 'EUR 42.91', 'EUR 14.303', 'EUR 14.303']],
             [['0.02', 'EUR'], [1, 1, 1, 1], ['EUR 0.01', 'EUR 0.01', 'EUR 0.00', 'EUR 0.00']],
             [['0.02', 'EUR'], [1, 1, 3, 1], ['EUR 0.01', 'EUR 0.00', 'EUR 0.01', 'EUR 0.00']],
+            [[-100, 'USD'], [30, 20, 40, 40], ['USD -23.08', 'USD -15.39', 'USD -30.77', 'USD -30.76']],
         ];
     }