Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZonedDateTime::getIntervalTo and Instant::getIntervalTo #81

Merged
merged 3 commits into from
Sep 26, 2023
Merged

ZonedDateTime::getIntervalTo and Instant::getIntervalTo #81

merged 3 commits into from
Sep 26, 2023

Conversation

solodkiy
Copy link
Contributor

@solodkiy solodkiy commented Sep 16, 2023 •
edited
Loading

More convenient way to get Interval from two ZonedDateTime.

$a->getIntervalTo($b);
// vs old version
Interval::of($a->getInstant(), $b->getInstant())

relates to #71

BenMorel
BenMorel reviewed Sep 23, 2023
View reviewed changes
src/Instant.php Outdated Show resolved Hide resolved
src/ZonedDateTime.php Outdated Show resolved Hide resolved
tests/InstantTest.php Outdated Show resolved Hide resolved
@solodkiy
Copy link
Contributor Author

@BenMorel fixed

@BenMorel BenMorel merged commit 8fdf91c into brick:master Sep 26, 2023
7 checks passed
@BenMorel
Copy link
Member

Thank you, released as 0.5.3!

@solodkiy solodkiy deleted the getIntervalTo branch September 27, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenMorel BenMorel BenMorel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solodkiy @BenMorel