Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Month enum everywhere #106

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented Mar 30, 2024

Covers :

  • MonthDay::of() + MonthDay::withMonth()
  • LocalDate::of() + LocalDate::withMonth()
  • LocalDateTime::of() + LocalDateTime::withMonth()
  • ZonedDateTime::withMonth()

And some code clean-up.

@gnutix gnutix force-pushed the local-date-allows-month-enum branch from 10ee151 to c739ba8 Compare March 30, 2024 09:43
@gnutix gnutix changed the title LocalDate::of() / LocalDate::withMonth() allows Month enum LocalDate::of() / LocalDate::withMonth() / LocalDateTime::of() / LocalDateTime::withMonth() / ZonedDateTime::withMonth() allows Month enum Mar 30, 2024
@gnutix gnutix changed the title LocalDate::of() / LocalDate::withMonth() / LocalDateTime::of() / LocalDateTime::withMonth() / ZonedDateTime::withMonth() allows Month enum Allows Month enum everywhere Mar 30, 2024
@BenMorel BenMorel merged commit a266063 into brick:master Mar 31, 2024
7 checks passed
@BenMorel
Copy link
Member

Thank you, @gnutix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants