Improvements for indexed-db #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The closure compiler trips on these as method names, so we simply use array-index syntax to access these properties.
|
ok, sorry I'm only getting to this now, I like it. I like it a lot. I think I might pull this into a branch and factor it in mainline --- stay tuned |
|
I fixed the webkit issue in a better way in #102 . I didn't tackle krestenkrab's API refactoring, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does a couple of things for indexed-db
eachasync_each, which lets the adapter implement theeachlogic without having to extract the list of keys first, and then iterate through them.async_eachfor the indexed-db adapterwebkitIDBTransaction(which sounds very webkit dependent)