LPS-128362 - Enable dartSass build option for themes #99625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-128362-pr-843-sender-bryceosterhaus-ts-1615216902814
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#843 (Took 2
ci:forwardattempts in 2 days 21 hours 44 minutes)@bryceosterhaus
@liferay-frontend
Original pull request comment:
This is not intended to be merged until @liferay/npm-scripts is merged with a greater version than v37.1.2
This PR is intended to be used with
liferay-theme-tasksv10.3.0which is included in the next npm-scripts release.I am sending this now as a draft now in case I am on leave when npm-scripts is updated. Feel free to test and merge once npm-scripts is updated.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 97c81548cc2c7aa05bc0f2a815c8d30b26549845
Sender Branch:
Branch Name: LPS-128362
1 out of 1jobs PASSEDBranch GIT ID: b89a80e27e5ad27f7d24d09414c5deff358fa01c
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 22 out of 24 jobs passed in 3 hours 24 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 7426a6a739b6ca42f7d8ae55a88aa1b0c9112dba
Upstream Comparison:
Branch GIT ID: 7426a6a739b6ca42f7d8ae55a88aa1b0c9112dba
Jenkins Build URL: Acceptance Upstream DXP (master) #1610
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 24 jobs PASSED
3 Failed Jobs:
test-portal-acceptance-pullrequest(master)test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/121 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at 7426a6a:
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
42 Tests Passed.
18 Tests Failed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
29 Tests Passed.
12 Tests Failed.