Skip to content

Commit

Permalink
service: fix win build service not listening for TCP/IPv4 conns
Browse files Browse the repository at this point in the history
  • Loading branch information
breuner committed Jul 29, 2023
1 parent 5d6e161 commit 8fee052
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
* Fixed compilation error (missing include directive) when building without S3 support.
* Fixed check for file slice smaller than block size in situations without direct IO.
* Fixed missing random IO flag in config file example.
* Fixed Windows build not listening for TCP/IPv4 connections in service mode.

### Contributors
* Thanks to Glenn K. Lockwood and Avi Drabkin for reporting an issues. Thanks to Jan Heichler, Rob Mallory, Maria Gutierrez for helpful comments and suggestions.
* Thanks to Glenn K. Lockwood, Avi Drabkin, Michael Bertelson for reporting an issues. Thanks to Jan Heichler, Rob Mallory, Maria Gutierrez for helpful comments and suggestions.

## v2.3.1 (Apr 10, 2023)

Expand Down
5 changes: 5 additions & 0 deletions source/HTTPServiceSWS.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ void HTTPServiceSWS::startServer()

defineServerResources(server);

#ifdef CYGWIN_SUPPORT
/* SWS defaults to listening for IPv6, which implies also IPv4 on linux, but is interpreted
as really only IPv6 and no IPv4 on cygwin, so rather force it to IPv4 only on cygwin. */
server.config.address = "0.0.0.0";
#endif
server.config.port = progArgs.getServicePort(); // desired port (std::promise confirms this)
std::promise<unsigned short> actualServerPort; // set by HttpServer after startup (0 for error)

Expand Down

0 comments on commit 8fee052

Please sign in to comment.