Handle empty templates #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the template returns without rendering anything, `Xray.augment_template` should not be called. The scenario might be a conditional `return` statement in a partial, to avoid it being rendered in some cases. Alternatively, `Xray.augment_template` could return immediately if the input source is nil?
|
Thanks for the PR! Is there any way I can test this to verify the behavior? For example, could you provide a gist containing a sample controller + view? Ideally I would like to include a test in the gem itself; if you have any thoughts on how that could be done, let me know and I can help you include it in this PR. Finally, in order to merge I need to you to add a CHANGELOG entry explaining your contribution. Thanks! |
|
@tobiashm @mattbrictson would be nice to merge this. @tobiashm any updates on creating a test/gist for this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the template returns without rendering anything,
Xray.augment_templateshould not be called.The scenario might be a conditional
returnstatement in a partial, to avoid it being rendered in some cases.Alternatively,
Xray.augment_templatecould return immediately if the input source is nil?