-
Notifications
You must be signed in to change notification settings - Fork 31
Various cleanup, tightening up, and switch to the official mongo image #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeffbyrnes
wants to merge
63
commits into
brennentsmith:master
Choose a base branch
from
jeffbyrnes:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbyrnes
commented
Jan 19, 2022
da39e2a
to
5bed952
Compare
@brennentsmith you’re welcome to tell me to buzz off w/ all this, but seemed like some nice cleanup & maintenance. |
Unnecessary w/ the main Compose config
The parent node:16 image already designates this.
It’s the default port.
* Bins are linked in such a way that you do not need paths * Add `*-daemon` scripts that start things via forever as long-running background services * Add `start` script to easily start up the scripts via forever * Fix `speedtest` script to point to correct file
* Uses Docker Volumes, avoiding issues w/ mounting a path for data * Uses an init script to set up the database, which is more clear
Sometimes handy to have a UI to inspect the MongoDB container
More data is nice, to see just how variable speeds are.
Makes it more clear how the npm scripts help run things
* More syntax highlighting * Consistent syntax & whitespace * Satisfy Markdown linter (mdl) * Show how to use `npx` to run tools like forever
* More syntax highlighting * Consistent syntax & whitespace * Satisfy Markdown linter (mdl) * Show how to use npm scripts with forever * Reorganize for clarity & less repetition
Ensures that a symlink or binary aren’t committed to source.
Ties the room together
Refactor to use official mongodb image, overall cleanup, automate build & push
Maybe this will let the builds work again
Provides a better example for operators
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…r/build-push-action-4 Bump docker/build-push-action from 3 to 4
* Drop multi-image build * Use the node image recommended WORKDIR
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5. - [Release notes](https://github.com/docker/metadata-action/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v4...v5) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ns/checkout-4 Bump actions/checkout from 3 to 4
…/login-action-3' * origin/dependabot/github_actions/docker/login-action-3: Bump docker/login-action from 2 to 3
…/metadata-action-5' * origin/dependabot/github_actions/docker/metadata-action-5: Bump docker/metadata-action from 4 to 5
…/build-push-action-5' * origin/dependabot/github_actions/docker/build-push-action-5: Bump docker/build-push-action from 4 to 5
Package Current Wanted Latest ======= ======= ====== ====== config 3.3.9 3.3.11 3.3.11 eslint 8.43.0 8.57.0 9.4.0 eslint-plugin-import 2.27.5 2.29.1 2.29.1 express 4.18.2 4.19.2 4.19.2 jquery 3.7.0 3.7.1 3.7.1 mongodb 4.16.0 4.17.2 6.7.0 nodemon 2.0.22 2.0.22 3.1.3 Signed-off-by: Jeff Byrnes <[email protected]>
Signed-off-by: Jeff Byrnes <[email protected]>
Signed-off-by: Jeff Byrnes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of things I ended up doing to make this logger work better on my Mac, whether run on bare metal or via Docker Compose.