Skip to content

Clear the colon when clearing the display #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mortenfyhn
Copy link

Hi, I've been testing out your library and I found that if I enable the colon, then clear the display, the colon persists.

For instance, this sketch will result in the colon staying lit:

#include <SevenSegmentTM1637.h>

void setup()
{
    auto display = SevenSegmentTM1637{7, MISO};

    display.setColonOn(true);
    display.print(1234);

    delay(1000);

    display.clear();
}

void loop() {}

I think the intended behaviour here is to clear everything when clear() is called, which is what I've suggested in this patch.

mortenfyhn added a commit to mortenfyhn/coffee-scales that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant