Skip to content

Commit

Permalink
Workaround a phpstan bug
Browse files Browse the repository at this point in the history 
Reported in phpstan/phpstan#2002
  • Loading branch information
@mnapoli
mnapoli committed Mar 15, 2019
1 parent f8a35d7 commit fc2c142
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions phpstan.neon.dist
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ parameters:
- %rootDir%/../../../tests/Bridge/Symfony/logs/*
- %rootDir%/../../../tests/Sam/Php/*
- %rootDir%/../../../tests/Sam/PhpFpm/*

ignoreErrors:
# https://github.com/phpstan/phpstan/pull/2002
- '#Strict comparison using === between int and false will always evaluate to false#'

3 comments on commit fc2c142

@adaamz
Copy link
Contributor

@adaamz adaamz commented on fc2c142 Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use ignoreErrors with path restriction, this is too wide - whole project.
https://github.com/phpstan/phpstan#ignore-error-messages-with-regular-expressions

@mnapoli
Copy link
Member Author

@mnapoli mnapoli commented on fc2c142 Mar 15, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adaamz
Copy link
Contributor

@adaamz adaamz commented on fc2c142 Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you use phpstan 0.10, but ignore error path resolution was added in 0.11 :-/

Please sign in to comment.