Fix regression in Serverless that caused the plugin to fail

> TypeError: Cannot read property 'bref' of undefined
brefphp · Jun 11, 2021 · 71f8821 · 71f8821
1 parent af366b5
commit 71f8821
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -71,10 +71,6 @@ class ServerlessPlugin {
             return delegate(variableString);
         }
 
-        // Check if bref custom directive is set, otherwise initialize it with empty object
-        this.serverless.service.custom = this.serverless.service.custom ? this.serverless.service.custom : {};
-        this.serverless.service.custom.bref = this.serverless.service.custom.bref ? this.serverless.service.custom.bref : {};
-
         this.hooks = {
             'before:package:setupProviderConfiguration': this.addCustomIamRoleForVendorArchiveDownload.bind(this),
             'package:setupProviderConfiguration': this.createVendorZip.bind(this),
@@ -95,7 +91,9 @@ class ServerlessPlugin {
     }
 
     addCustomIamRoleForVendorArchiveDownload() {
-        if(! this.serverless.service.custom.bref.separateVendor) {
+        this.serverless.service.custom = this.serverless.service.custom ? this.serverless.service.custom : {};
+        this.serverless.service.custom.bref = this.serverless.service.custom.bref ? this.serverless.service.custom.bref : {};
+        if (! this.serverless.service.custom.bref.separateVendor) {
             return;
         }
 
@@ -139,6 +137,8 @@ class ServerlessPlugin {
     }
 
     async createVendorZip() {
+        this.serverless.service.custom = this.serverless.service.custom ? this.serverless.service.custom : {};
+        this.serverless.service.custom.bref = this.serverless.service.custom.bref ? this.serverless.service.custom.bref : {};
         if(! this.serverless.service.custom.bref.separateVendor) {
             return;
         }
@@ -222,6 +222,8 @@ class ServerlessPlugin {
     }
 
     async uploadVendorZip() {
+        this.serverless.service.custom = this.serverless.service.custom ? this.serverless.service.custom : {};
+        this.serverless.service.custom.bref = this.serverless.service.custom.bref ? this.serverless.service.custom.bref : {};
         if(! this.serverless.service.custom.bref.separateVendor) {
             return;
         }