Use a transparent placeholder when transitioning Podcast chapter image #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
changed the title
erdemyerebasmaz
force-pushed
the
podcast_chapter_image_transition
branch
from
38551bb to
249d354
Compare
roeierez
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #583
Blue placeholder is replaced with a transparent one.
While this is possible, it requires a product decision and won't be addressed as part of this PR.
Changelist:
Demonstration
Picked a Podcast with many chapters with different images in a short timeframe:
petal_20240517_115738.mp4
petal_20240517_121214.mp4
First half of the video showcases transition animation without caching, which was addressed.
Second half of the video showcases transition animation with the images cached, which wasn't changed.
Reproduces on light theme as well.